tkhurana commented on code in PR #1736:
URL: https://github.com/apache/phoenix/pull/1736#discussion_r1450786126
##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/PagingRegionScanner.java:
##########
@@ -72,15 +96,10 @@ private boolean next(List<Cell> results, boolean raw)
throws IOException {
// There is no more row from the HBase region scanner. We need
to check if PageFilter
// has stopped the region scanner
if (pagingFilter.isStopped()) {
- // Close the current region scanner, start a new one and
return a dummy result
- delegate.close();
- byte[] rowKey = pagingFilter.getRowKeyAtStop();
- boolean isInclusive = pagingFilter.isNextRowInclusive();
- scan.withStartRow(rowKey, isInclusive);
- delegate = region.getScanner(scan);
+ byte[] rowKey =
pagingFilter.getCurrentRowKeyToBeExcluded();
Review Comment:
move this to inside the `if (results.isEmpty())`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
