virajjasani commented on code in PR #1736:
URL: https://github.com/apache/phoenix/pull/1736#discussion_r1450801693
##########
phoenix-core-client/src/main/java/org/apache/phoenix/filter/PagingFilter.java:
##########
@@ -71,30 +68,21 @@ public void setDelegateFilter (Filter delegate) {
this.delegate = delegate;
}
- public byte[] getRowKeyAtStop() {
+ public byte[] getCurrentRowKeyToBeExcluded() {
byte[] rowKeyAtStop = null;
- if (nextHintCell != null) {
- // if we have already seeked to the next cell use that when we
resume the scan
- rowKeyAtStop = CellUtil.cloneRow(nextHintCell);
- } else if (currentCell != null) {
+ if (currentCell != null) {
Review Comment:
currentCell would never be null because this is called only when paging
filter stops. PagingFilter is stopped by:
```
if (state == State.STARTED && currentCell != null
&& currentTime - startTime >= pageSizeMs) {
state = State.TIME_TO_STOP;
}
```
Hence, only if currentCell is not null, `TIME_TO_STOP` is set to stop the
filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
