[
https://issues.apache.org/jira/browse/PHOENIX-7015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808271#comment-17808271
]
ASF GitHub Bot commented on PHOENIX-7015:
-----------------------------------------
haridsv commented on code in PR #1794:
URL: https://github.com/apache/phoenix/pull/1794#discussion_r1457558693
##########
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/CDCGlobalIndexRegionScanner.java:
##########
@@ -271,6 +281,7 @@ private Result getCDCImage(
protected void scanDataTableRows(long startTime) throws IOException {
super.scanDataTableRows(startTime);
List<List<Cell>> indexRowList = new ArrayList<>();
+ Map<Long, ImmutableBytesPtr> indexDeleteFamilyCellMap = new
HashMap<>();
Review Comment:
Just wondering why you are using this intermediate variable.
##########
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/CDCGlobalIndexRegionScanner.java:
##########
@@ -76,6 +77,8 @@ public class CDCGlobalIndexRegionScanner extends
UncoveredGlobalIndexRegionScann
// Map<dataRowKey: Map<TS: Map<qualifier: Cell>>>
private Set<PTable.CDCChangeScope> cdcChangeScopeSet;
+ private Map<Long, ImmutableBytesPtr> indexDeleteFamilyCellMap;
Review Comment:
Now that you changed the value type per our offline discussion, this can be
better named. How about `deleteFamilyTS2DataRowKeyMap`?
> Extend UncoveredGlobalIndexRegionScanner for CDC region scanner usecase
> -----------------------------------------------------------------------
>
> Key: PHOENIX-7015
> URL: https://issues.apache.org/jira/browse/PHOENIX-7015
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Viraj Jasani
> Priority: Major
>
> For CDC region scanner usecase, extend UncoveredGlobalIndexRegionScanner to
> CDCUncoveredGlobalIndexRegionScanner. The new region scanner for CDC performs
> raw scan to index table and retrieve data table rows from index rows.
> Using the time range, it can form a JSON blob to represent changes to the row
> including pre and/or post row images.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
