[
https://issues.apache.org/jira/browse/PHOENIX-7015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814399#comment-17814399
]
ASF GitHub Bot commented on PHOENIX-7015:
-----------------------------------------
TheNamesRai commented on code in PR #1813:
URL: https://github.com/apache/phoenix/pull/1813#discussion_r1478425940
##########
phoenix-core/src/main/java/org/apache/phoenix/util/CDCUtil.java:
##########
@@ -110,4 +109,25 @@ public static Scan initForRawScan(Scan scan) {
}
return scan;
}
+
+ public static int compareCellFamilyAndQualifier(byte[] columnFamily1,
+ byte[] columnQual1,
+ byte[] columnFamily2,
+ byte[] columnQual2) {
+ int familyNameComparison = CDCUtil.compare(columnFamily1,
columnFamily2);
+ if (familyNameComparison != 0) {
+ return familyNameComparison;
+ }
+ return CDCUtil.compare(columnQual1, columnQual2);
Review Comment:
Arrays.compare is available after Java 9. To keep supporting Java 8, i
created a new function to do the same.
As per it's implementation, both seems equally efficient.
> Extend UncoveredGlobalIndexRegionScanner for CDC region scanner usecase
> -----------------------------------------------------------------------
>
> Key: PHOENIX-7015
> URL: https://issues.apache.org/jira/browse/PHOENIX-7015
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Viraj Jasani
> Priority: Major
>
> For CDC region scanner usecase, extend UncoveredGlobalIndexRegionScanner to
> CDCUncoveredGlobalIndexRegionScanner. The new region scanner for CDC performs
> raw scan to index table and retrieve data table rows from index rows.
> Using the time range, it can form a JSON blob to represent changes to the row
> including pre and/or post row images.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
