virajjasani commented on code in PR #1736:
URL: https://github.com/apache/phoenix/pull/1736#discussion_r1458078355
##########
phoenix-core-client/src/main/java/org/apache/phoenix/iterate/OrderedResultIterator.java:
##########
@@ -151,6 +159,14 @@ public Expression apply(OrderByExpression column) {
private Tuple dummyTuple = null;
private long byteSize;
private long pageSizeMs;
+ private Scan scan;
+ private byte[] scanStartRowKey;
+ private byte[] prevScanStartRowKey;
+ private Boolean prevScanIncludeStartRowKey;
Review Comment:
We need Boolean here because only server side execution of this iterator
sets this value so we have check in place to see if the value is not null.
e.g.
```
if (firstScan && serverSideIterator && prevScanStartRowKey !=
null &&
prevScanIncludeStartRowKey != null) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]