tkhurana commented on code in PR #1736:
URL: https://github.com/apache/phoenix/pull/1736#discussion_r1479061221
##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java:
##########
@@ -230,10 +238,17 @@ private static final class InMemoryGroupByCache
implements GroupByCache {
private final ServerAggregators aggregators;
private final RegionCoprocessorEnvironment env;
private final byte[] customAnnotations;
+ private final ConcurrentMap<ImmutableBytesWritable,
ImmutableBytesWritable>
Review Comment:
Any reason why you are using `ImmutableBytesWritable` vs aggregateMap is
using `ImmutableBytesPtr` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
