tkhurana commented on code in PR #1736:
URL: https://github.com/apache/phoenix/pull/1736#discussion_r1480655717
##########
phoenix-core-client/src/main/java/org/apache/phoenix/iterate/OrderedResultIterator.java:
##########
@@ -172,6 +188,28 @@ public OrderedResultIterator(ResultIterator delegate,
this(delegate, orderByExpressions, spoolingEnabled, thresholdBytes,
limit, offset, estimatedRowSize, Long.MAX_VALUE);
}
+ public OrderedResultIterator(ResultIterator delegate,
+ List<OrderByExpression> orderByExpressions,
+ boolean spoolingEnabled,
+ long thresholdBytes, Integer limit, Integer
offset,
+ int estimatedRowSize, long pageSizeMs, Scan
scan,
+ RegionInfo regionInfo) {
+ this(delegate, orderByExpressions, spoolingEnabled, thresholdBytes,
limit, offset,
+ estimatedRowSize, pageSizeMs);
+ this.scan = scan;
+ // If scan start rowkey is empty, use region boundaries. Reverse
region boundaries
+ // for reverse scan.
+ this.scanStartRowKey = scan.getStartRow().length > 0 ?
scan.getStartRow() :
Review Comment:
I see this logic being used in many places. If we can add a util function
for this too it will be helpful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
