tkhurana commented on code in PR #1736:
URL: https://github.com/apache/phoenix/pull/1736#discussion_r1480438637
##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java:
##########
@@ -411,6 +487,115 @@ private UnorderedGroupByRegionScanner(final
ObserverContext<RegionCoprocessorEnv
@Override
public boolean next(List<Cell> resultsToReturn) throws IOException {
+ if (firstScan && prevScanStartRowKey != null &&
prevScanIncludeStartRowKey != null) {
+ firstScan = false;
Review Comment:
Can't this logic when `firstScan` is true moved into the constructor and
then we can remove this variable. One less state to maintain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
