[
https://issues.apache.org/jira/browse/PHOENIX-7081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820960#comment-17820960
]
ASF GitHub Bot commented on PHOENIX-7081:
-----------------------------------------
stoty commented on code in PR #1808:
URL: https://github.com/apache/phoenix/pull/1808#discussion_r1503646346
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/ParameterizedIndexUpgradeToolIT.java:
##########
@@ -115,7 +114,7 @@ public class ParameterizedIndexUpgradeToolIT extends
BaseTest {
@BeforeClass
public static synchronized void saveTmp () throws Exception {
- tmpDir = System.getProperty("java.io.tmpdir");
+ tmpPath = System.getProperty("java.io.tmpdir");
Review Comment:
See the comment above.
the tmpdir values originally set, and re-set by minicluster must be kept
separate.
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/ParameterizedIndexUpgradeToolIT.java:
##########
@@ -87,9 +87,9 @@ public class ParameterizedIndexUpgradeToolIT extends BaseTest
{
private static final String [] TABLE_LIST_NAMESPACE_SIMPLIFIED = new
String[1];
private static final String [] TRANSACTIONAL_TABLE_LIST = new String[1];
-
+ private static String tmpPath = System.getProperty("java.io.tmpdir");
private static String INPUT_LIST = "";
- private static final String INPUT_FILE =
"/tmp/input_file_index_upgrade.csv";
+ private static final String INPUT_FILE = tmpPath +
"/input_file_index_upgrade.csv";
Review Comment:
This is where you use the the saved tmpdir.
You should instead use tmpPath which is read AFTER minicluster is started,
which can be a different value (depending onm HBase / Hadoop version)
> Replace /tmp with {java.io.tmpdir} in tests
> -------------------------------------------
>
> Key: PHOENIX-7081
> URL: https://issues.apache.org/jira/browse/PHOENIX-7081
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Reporter: Istvan Toth
> Assignee: Divneet Kaur
> Priority: Minor
> Labels: beginner, test
>
> I was running two test suites in parallel on a large VM, and it seems that
> OrphanViewToolIT cannot handle that.
> {noformat}
> java.io.FileNotFoundException: /tmp/OrphanView.txt (No such file or
> directory){noformat}
> Use some directory here that is under the source code's root.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
