[ 
https://issues.apache.org/jira/browse/PHOENIX-7081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820962#comment-17820962
 ] 

ASF GitHub Bot commented on PHOENIX-7081:
-----------------------------------------

stoty commented on code in PR #1808:
URL: https://github.com/apache/phoenix/pull/1808#discussion_r1503646346


##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/ParameterizedIndexUpgradeToolIT.java:
##########
@@ -115,7 +114,7 @@ public class ParameterizedIndexUpgradeToolIT extends 
BaseTest {
 
     @BeforeClass
     public static synchronized void saveTmp () throws Exception {
-        tmpDir = System.getProperty("java.io.tmpdir");
+        tmpPath = System.getProperty("java.io.tmpdir");

Review Comment:
   See the comment above.
   the tmpdir values originally set, and re-set by minicluster must be kept 
separate.
   
   Using the same tmpPath name we use elsewhere for constructing the test paths 
for saving the value leads to misunderstanding and errors like the one above.
   
   You could keep the tmpDir name here, or use something like originalTmpDir.





> Replace /tmp with {java.io.tmpdir} in tests
> -------------------------------------------
>
>                 Key: PHOENIX-7081
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-7081
>             Project: Phoenix
>          Issue Type: Bug
>          Components: core
>            Reporter: Istvan Toth
>            Assignee: Divneet Kaur
>            Priority: Minor
>              Labels: beginner, test
>
> I was running two test suites in parallel on a large VM, and it seems that 
> OrphanViewToolIT cannot handle that.
> {noformat}
> java.io.FileNotFoundException: /tmp/OrphanView.txt (No such file or 
> directory){noformat}
> Use some directory here that is under the source code's root.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to