shahrs87 commented on code in PR #1838:
URL: https://github.com/apache/phoenix/pull/1838#discussion_r1506718473
##########
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ConnectionInfo.java:
##########
@@ -114,6 +115,15 @@ public static ConnectionInfo create(String url,
ReadOnlyProps props, Properties
return create(url, conf, props, info);
}
+ public static ConnectionInfo create(String url, ReadOnlyProps props,
+ Properties info, boolean isServerConnection)
+ throws SQLException {
+ Configuration conf =
HBaseFactoryProvider.getConfigurationFactory().getConfiguration();
+ ConnectionInfo connInfo = create(url, conf, props, info);
+ connInfo.isServerConnection = isServerConnection;
Review Comment:
All the other variables are being set via Builder. Lets not break that
pattern for `isServerConnection`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
