palashc commented on code in PR #1838:
URL: https://github.com/apache/phoenix/pull/1838#discussion_r1506758361
##########
phoenix-core/src/test/java/org/apache/phoenix/jdbc/PhoenixTestDriver.java:
##########
@@ -92,7 +93,8 @@ public synchronized Connection connect(String url, Properties
info) throws SQLEx
public synchronized ConnectionQueryServices
getConnectionQueryServices(String url, Properties infoIn) throws SQLException {
checkClosed();
final Properties info = PropertiesUtil.deepCopy(infoIn);
- ConnectionInfo connInfo = ConnectionInfo.create(url, null, info);
+ boolean isServerConnection =
Boolean.valueOf(info.getProperty(QueryUtil.IS_SERVER_CONNECTION));
+ ConnectionInfo connInfo = ConnectionInfo.create(url, null, info,
isServerConnection);
Review Comment:
Pushed the refactor, no changes in Drivers needed.
##########
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ConnectionInfo.java:
##########
@@ -114,6 +115,15 @@ public static ConnectionInfo create(String url,
ReadOnlyProps props, Properties
return create(url, conf, props, info);
}
+ public static ConnectionInfo create(String url, ReadOnlyProps props,
+ Properties info, boolean isServerConnection)
+ throws SQLException {
+ Configuration conf =
HBaseFactoryProvider.getConfigurationFactory().getConfiguration();
+ ConnectionInfo connInfo = create(url, conf, props, info);
+ connInfo.isServerConnection = isServerConnection;
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
