stoty commented on code in PR #148:
URL: 
https://github.com/apache/phoenix-queryserver/pull/148#discussion_r1509892067


##########
python-phoenixdb/phoenixdb/types.py:
##########
@@ -298,6 +298,8 @@ def from_column(column):
 
     @staticmethod
     def _from_jdbc(jdbc_code):
+        if jdbc_code == 0:

Review Comment:
   This is a bit ugly.
   Would it be possible to add this to the type maps instead ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to