stoty commented on code in PR #148:
URL:
https://github.com/apache/phoenix-queryserver/pull/148#discussion_r1509923536
##########
python-phoenixdb/phoenixdb/types.py:
##########
@@ -222,9 +225,9 @@ def __cmp__(self, other):
(2011, common_pb2.STRING), # NCLOB
(2009, common_pb2.STRING), # SQLXML
# Returned by Avatica for Arrays in EMPTY resultsets
- (2000, common_pb2.BYTE_STRING) # JAVA_OBJECT
+ (2000, common_pb2.BYTE_STRING), # JAVA_OBJECT
# These are defined by JDBC, but cannot be mapped
- # NULL
+ (0, common_pb2.NULL) # NULL
Review Comment:
The comment is obviously not true for this one.
Please move this to the start (in numerical order)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
