dbwong commented on PR #1848: URL: https://github.com/apache/phoenix/pull/1848#issuecomment-1984753107
@virajjasani This change as setup minimally looks reasonable to me... one area i do think we may need to be careful on however is the single threadedness of the HConnection... I didn't look into the details of how you were optimizing the but we should be careful not to allow multiple calls into the new getTableRegions(byte[] tableName, byte[] startRowKey, byte[] endRowKey) from multiple threads especially since they can somewhat overlap to a degree and while i haven't looked in detail i have a small concern about things like [phoenix-core-client/src/main/java/org/apache/phoenix/iterate/DefaultParallelScanGrouper.java](https://github.com/apache/phoenix/pull/1848/files#diff-f487983a399ca9d3c947e1b8b3a5093791b4a0947395851cee4bae006a4236cd) doing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
