shahrs87 commented on code in PR #1854:
URL: https://github.com/apache/phoenix/pull/1854#discussion_r1525314684
##########
phoenix-core/src/test/java/org/apache/phoenix/cache/ServerMetadataCacheIT.java:
##########
@@ -85,13 +89,13 @@
public class ServerMetadataCacheIT extends ParallelStatsDisabledIT {
private final Random RANDOM = new Random(42);
- private final long NEVER = (long)
ConnectionProperty.UPDATE_CACHE_FREQUENCY.getValue("NEVER");
private static ServerName serverName;
@BeforeClass
public static synchronized void doSetup() throws Exception {
Map<String, String> props = Maps.newHashMapWithExpectedSize(1);
+ props.put(QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB,
Long.toString(Long.MAX_VALUE));
Review Comment:
```suggestion
props.put(QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB,
(long) ConnectionProperty.UPDATE_CACHE_FREQUENCY.getValue("NEVER"););
```
##########
phoenix-core/src/test/java/org/apache/phoenix/cache/ServerMetadataCacheIT.java:
##########
@@ -1700,9 +1704,109 @@ public void testInheritedIndexOnTenantViews(boolean
sameTenantViewNames) throws
}
}
+ /**
+ * Test that a client can learn about the changes to a base table's
+ * sequence number after a view is created on the table.
+ */
+ @Test
+ public void testBaseTableSequenceNumberAfterCreateView() throws Exception {
Review Comment:
Do we need this test? AlterTableIT#testAddingColumnsToTablesAndViews does
the exact same thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
