palashc commented on code in PR #1854:
URL: https://github.com/apache/phoenix/pull/1854#discussion_r1525364840


##########
phoenix-core-client/src/main/java/org/apache/phoenix/compile/FromCompiler.java:
##########
@@ -280,7 +280,7 @@ public static ColumnResolver getResolver(NamedTableNode 
tableNode, PhoenixConnec
 
     public static ColumnResolver getResolver(SingleTableStatement statement, 
PhoenixConnection connection)
             throws SQLException {
-        SingleTableColumnResolver visitor = new 
SingleTableColumnResolver(connection, statement.getTable(), true);

Review Comment:
   Yes. 
   Confirmed from SetPropertyIT that setting property on table/view goes 
through `ExecutableAddColumnStatement` and that uses the resolver change we 
made.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to