palashc commented on code in PR #1859:
URL: https://github.com/apache/phoenix/pull/1859#discussion_r1562953056


##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableWithViewsIT.java:
##########
@@ -1149,10 +1152,8 @@ public void testDroppingIndexedColDropsViewIndex() 
throws Exception {
             byte[] viewIndexPhysicalTable = 
viewIndex.getPhysicalName().getBytes();
             assertNotNull("Can't find view index", viewIndex);
             assertEquals("Unexpected number of indexes ", 2, 
view.getIndexes().size());
-            assertEquals("Unexpected index ",  fullNameViewIndex1 , 
view.getIndexes().get(0).getName()

Review Comment:
   The asserts here assume a certain ordering of indexes in the view's PTable 
but that ordering does not hold if the view PTable was refreshed in the 
client's cache. So I changed the asserts to look for the index name in a list 
of expected index names.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to