palashc commented on code in PR #1859:
URL: https://github.com/apache/phoenix/pull/1859#discussion_r1562956356


##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/LogicalTableNameBaseIT.java:
##########
@@ -530,13 +531,16 @@ protected void validateIndex(Connection connection, 
String tableName, boolean is
     }
 
     public static void renameAndDropPhysicalTable(Connection conn, String 
tenantId, String schema, String tableName, String physicalName, boolean 
isNamespaceEnabled) throws Exception {
+        // if client is validating last_ddl_timestamp, this change in physical 
table name should be visible to the client

Review Comment:
   We will have to make the change in our light fork then. Keeping this change 
does not affect the test even with UCF=always. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to