palashc commented on code in PR #1883:
URL: https://github.com/apache/phoenix/pull/1883#discussion_r1639016166
##########
phoenix-core-client/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java:
##########
@@ -368,10 +371,27 @@ public class QueryServicesOptions {
//Security defaults
public static final boolean DEFAULT_PHOENIX_ACLS_ENABLED = false;
- //default update cache frequency
- public static final long DEFAULT_UPDATE_CACHE_FREQUENCY = 0;
public static final int DEFAULT_SMALL_SCAN_THRESHOLD = 100;
+ /**
+ * Metadata caching configs, see
https://issues.apache.org/jira/browse/PHOENIX-6883.
+ * Disable the boolean flags and set UCF=always to disable the caching
re-design.
+ *
+ * Disable caching re-design if you use Online Data Format Change since
the cutover logic
+ * is currently incompatible and clients may not learn about the physical
table change.
+ * See https://issues.apache.org/jira/browse/PHOENIX-7284.
+ *
+ * Disable caching re-design if your clients will not have ADMIN perms to
call region server
+ * RPC. See https://issues.apache.org/jira/browse/HBASE-28508
+ */
+ public static final long DEFAULT_UPDATE_CACHE_FREQUENCY
+ = (long)
ConnectionProperty.UPDATE_CACHE_FREQUENCY.getValue("ALWAYS");
+ public static final boolean DEFAULT_LAST_DDL_TIMESTAMP_VALIDATION_ENABLED
= false;
+ public static final boolean
DEFAULT_PHOENIX_METADATA_INVALIDATE_CACHE_ENABLED = false;
Review Comment:
These are the client-side/server-side flags we would use to enable the
feature.
`DEFAULT_LAST_DDL_TIMESTAMP_VALIDATION_ENABLED` used in helper methods in
`ValidateLastDDLTimestampUtil` which client uses to decide whether to validate
timestamps and `DEFAULT_PHOENIX_METADATA_INVALIDATE_CACHE_ENABLED` in
`CQSI.invalidateServerMetadataCache` to decide whether to invalidate cache on
server side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
