palashc commented on code in PR #1883:
URL: https://github.com/apache/phoenix/pull/1883#discussion_r1640397328
##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java:
##########
@@ -3529,6 +3566,19 @@ private MetaDataMutationResult mutateColumn(
}
}
+ private void
invalidateServerMetadataCache(List<InvalidateServerMetadataCacheRequest>
requests)
+ throws Throwable {
+ Properties properties = new Properties();
Review Comment:
Yes I believe we could!
But there are multiple places we are invalidating server cache from and
there could be more in the future. Assuming we don't do a lot of DDL changes
which invalidate the cache, maybe it is okay to keep the check in one place? We
could move it to this method in MDEI instead of keeping it in CQSI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
