kadirozde commented on code in PR #1936:
URL: https://github.com/apache/phoenix/pull/1936#discussion_r1794642687
##########
phoenix-core-server/src/main/java/org/apache/phoenix/iterate/NonAggregateRegionScannerFactory.java:
##########
@@ -298,6 +303,24 @@ static OrderedResultIterator deserializeFromScan(Scan
scan, RegionScanner s,
}
}
+ private static class IteratorAndContext {
Review Comment:
I did not understand what we are achieving here. OrderedResultIterator is
used in both client and server side. So, we need to add the next() with
ScannerContext method to OrderedResultIterator too. This method will be used on
the server side. The scanner context should not serialized/deserialized. We
also need to pass through ScannerContext context for the other result iterators
used on the server side (for example, OffsetResultIterator). Also let us add
tests for these result iterators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
