palashc commented on code in PR #1936:
URL: https://github.com/apache/phoenix/pull/1936#discussion_r1797491950
##########
phoenix-core-server/src/main/java/org/apache/phoenix/iterate/NonAggregateRegionScannerFactory.java:
##########
@@ -298,6 +303,24 @@ static OrderedResultIterator deserializeFromScan(Scan
scan, RegionScanner s,
}
}
+ private static class IteratorAndContext {
Review Comment:
As discussed offline, the changes in this class help with linking the
RegionScanner from NonAggregateRegionScannerFactory to the
RegionScannerResultIterator, thus bypassing the ResultIterators in between
since the current codebase structure makes it difficult to pass the
ScannerContext through them on the server side.
I have also renamed the inner class used here to more meaningful
`OrderedResultIteratorWithScannerContext`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]