[
https://issues.apache.org/jira/browse/PHOENIX-7407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936645#comment-17936645
]
ASF GitHub Bot commented on PHOENIX-7407:
-----------------------------------------
stoty commented on PR #145:
URL:
https://github.com/apache/phoenix-connectors/pull/145#issuecomment-2734936506
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 6m 8s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 2m 26s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 8s | root in master failed. |
| -1 :x: | compile | 0m 9s | phoenix5-spark in master failed. |
| -1 :x: | compile | 0m 9s | phoenix5-spark3 in master failed. |
| +1 :green_heart: | checkstyle | 0m 28s | master passed |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark in master failed. |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark3 in master failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark in master failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark3 in master failed. |
| -1 :x: | spotbugs | 0m 9s | phoenix5-spark in master failed. |
| -1 :x: | spotbugs | 0m 9s | phoenix5-spark3 in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 6s | root in the patch failed. |
| -1 :x: | compile | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | compile | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | javac | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | javac | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | scalac | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | scalac | 0m 9s | phoenix5-spark3 in the patch failed. |
| +1 :green_heart: | checkstyle | 0m 8s | phoenix5-spark: The patch
generated 0 new + 5 unchanged - 2 fixed = 5 total (was 7) |
| -1 :x: | checkstyle | 0m 8s | phoenix5-spark3: The patch generated 4
new + 7 unchanged - 2 fixed = 11 total (was 9) |
| -1 :x: | markdownlint | 0m 4s | The patch generated 3 new + 134
unchanged - 1 fixed = 137 total (was 135) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML
file. |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark in the patch failed. |
| -1 :x: | spotbugs | 0m 9s | phoenix5-spark3 in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | unit | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | asflicense | 0m 15s | The patch generated 7 ASF License
warnings. |
| | | 13m 13s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.48 ServerAPI=1.48 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/145 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile
markdownlint spotbugs hbaseanti checkstyle scalac scaladoc |
| uname | Linux 0dcb5dcd40ac 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18
17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / 09afb21 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/branch-mvninstall-root.txt
|
| compile |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/branch-compile-phoenix5-spark.txt
|
| compile |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/branch-compile-phoenix5-spark3.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark3.txt
|
| scaladoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark.txt
|
| scaladoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark3.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark3.txt
|
| mvninstall |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-mvninstall-root.txt
|
| compile |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt
|
| compile |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt
|
| javac |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt
|
| javac |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt
|
| scalac |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt
|
| scalac |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/diff-checkstyle-phoenix5-spark3.txt
|
| markdownlint |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/diff-patch-markdownlint.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark3.txt
|
| scaladoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark.txt
|
| scaladoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark3.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark3.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-unit-phoenix5-spark.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-unit-phoenix5-spark3.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/testReport/
|
| asflicense |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-asflicense-problems.txt
|
| Max. process+thread count | 47 (vs. ulimit of 30000) |
| modules | C: phoenix5-spark phoenix5-spark3 U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/console
|
| versions | git=2.7.4 maven=3.3.9 markdownlint=0.22.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> Remove deprecated datasource V1 code from spark2 and spark3 connector
> ---------------------------------------------------------------------
>
> Key: PHOENIX-7407
> URL: https://issues.apache.org/jira/browse/PHOENIX-7407
> Project: Phoenix
> Issue Type: Improvement
> Reporter: rejeb ben rejeb
> Assignee: rejeb ben rejeb
> Priority: Major
>
> The pupose of this jira is to remove deprecated datasource V1 code. It is
> safe to remove these classes since they are used internally by spark and not
> referenced directly in applications code.
> But in order to not impact old applications, all V1 interfaces (utlity
> methods and the source type "org.apache.phoenix.spark") will be kept and code
> will modified to use new connector version classes.
> As dfiscussed on dev mailing list, one acceptable side effect is that spark3
> SameMode will accept both "Append" and "Overwrite" values. However behavior
> will be the same.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
