[ https://issues.apache.org/jira/browse/PHOENIX-7407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954357#comment-17954357 ]
ASF GitHub Bot commented on PHOENIX-7407: ----------------------------------------- stoty commented on PR #145: URL: https://github.com/apache/phoenix-connectors/pull/145#issuecomment-2912803113 > Overwrite mode have'nt been implement respecting Spark definition for this mode. What would the expected behaviour be ? > Remove deprecated datasource V1 code from spark2 and spark3 connector > --------------------------------------------------------------------- > > Key: PHOENIX-7407 > URL: https://issues.apache.org/jira/browse/PHOENIX-7407 > Project: Phoenix > Issue Type: Improvement > Reporter: rejeb ben rejeb > Assignee: rejeb ben rejeb > Priority: Major > > The pupose of this jira is to remove deprecated datasource V1 code. It is > safe to remove these classes since they are used internally by spark and not > referenced directly in applications code. > But in order to not impact old applications, all V1 interfaces (utlity > methods and the source type "org.apache.phoenix.spark") will be kept and code > will modified to use new connector version classes. > As dfiscussed on dev mailing list, one acceptable side effect is that spark3 > SameMode will accept both "Append" and "Overwrite" values. However behavior > will be the same. -- This message was sent by Atlassian Jira (v8.20.10#820010)