NihalJain commented on code in PR #2024:
URL: https://github.com/apache/phoenix/pull/2024#discussion_r2047046966
##########
phoenix-core-client/src/main/java/org/apache/phoenix/compile/BindManager.java:
##########
@@ -20,61 +20,52 @@
import java.sql.ParameterMetaData;
import java.sql.SQLException;
import java.util.List;
-
import org.apache.phoenix.exception.SQLExceptionCode;
import org.apache.phoenix.exception.SQLExceptionInfo;
import org.apache.phoenix.jdbc.PhoenixParameterMetaData;
import org.apache.phoenix.parse.BindParseNode;
import org.apache.phoenix.schema.PDatum;
-
/**
- *
- * Class that manages binding parameters and checking type matching. There are
- * two main usages:
- *
- * 1) the standard query case where we have the values for the binds.
- * 2) the retrieve param metadata case where we don't have the bind values.
- *
- * In both cases, during query compilation we figure out what type the bind
variable
- * "should" be, based on how it's used in the query. For example {@code foo <
? } would expect
- * that the bind variable type matches or can be coerced to the type of foo.
For (1),
- * we check that the bind value has the correct type and for (2) we set the
param
+ * Class that manages binding parameters and checking type matching. There are
two main usages: 1)
Review Comment:
fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
