lfrancke commented on PR #2024: URL: https://github.com/apache/phoenix/pull/2024#issuecomment-3084067464
So, I checked about 50 files at random and they all looked good to me. I also skimmed the entire list of 1500+ changed files and did not see anything that looks "wrong" (as in: generated files, binaries, build artifacts etc.). I searched for antlr and a few other things, didn't see anything... The only thing that I spotted (which is probably still irrelevant) are the test scenarios in `phoenix-pherf` where XML is changed slightly (but only whitespace) and I doubt that this is checked in the tests but I didn't run them. From my amateur point of view this looks good! Thank you for keeping at it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
