tkhurana commented on code in PR #2134:
URL: https://github.com/apache/phoenix/pull/2134#discussion_r2078072188


##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java:
##########
@@ -611,6 +612,29 @@ private boolean areMutationsInSameTable(Table 
targetHTable, Region region) {
                 region.getTableDescriptor().getTableName().getName()) == 0);
     }
 
+    @Override
+    public InternalScanner 
preFlush(ObserverContext<RegionCoprocessorEnvironment> c, Store store,
+                                    InternalScanner scanner, 
FlushLifeCycleTracker tracker)
+            throws IOException {
+        if (!isPhoenixTableTTLEnabled(c.getEnvironment().getConfiguration())) {

Review Comment:
   @sanjeet006py Instead of relying on metrics you could also use the log 
messages when flush happens. For example `2025-05-07 16:47:34,580 INFO  
[MemStoreFlusher.1] regionserver.HRegion - Finished flush of dataSize ~255.34 
MB/267746710, heapSize ~256.01 MB/268445696, currentSize=10.04 MB/10529365 for 
397f5412f43294d01081c54d7253d378 in 1986ms, sequenceid=207416387, compaction 
requested=false"`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to