sanjeet006py commented on code in PR #2134:
URL: https://github.com/apache/phoenix/pull/2134#discussion_r2078205495


##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java:
##########
@@ -611,6 +612,29 @@ private boolean areMutationsInSameTable(Table 
targetHTable, Region region) {
                 region.getTableDescriptor().getTableName().getName()) == 0);
     }
 
+    @Override
+    public InternalScanner 
preFlush(ObserverContext<RegionCoprocessorEnvironment> c, Store store,
+                                    InternalScanner scanner, 
FlushLifeCycleTracker tracker)
+            throws IOException {
+        if (!isPhoenixTableTTLEnabled(c.getEnvironment().getConfiguration())) {

Review Comment:
   > Does that have the same problem too ?
   
   Yes as this log line only tells us how much time all the stores which were 
to be flushed took to flush data as total. I added a log line in StoreFlusher 
and will test with that now. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to