virajjasani commented on code in PR #2176:
URL: https://github.com/apache/phoenix/pull/2176#discussion_r2136844678
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/OnDuplicateKey2IT.java:
##########
@@ -589,10 +577,6 @@ public void testReturnRowResultWithoutAutoCommit() throws
Exception {
"IGNORE";
validateReturnedRowAfterUpsert(conn, upsertSql, tableName,
1011.202, null, true,
bsonDocument1, bsonDocument1, 123);
- throw new RuntimeException("Should not reach here");
- } catch (SQLException e) {
-
Assert.assertEquals(SQLExceptionCode.AUTO_COMMIT_NOT_ENABLED.getErrorCode(),
Review Comment:
Without auto-commit, we won't be able to return ResultSet, correct?
##########
phoenix-core/src/test/java/org/apache/phoenix/compile/PhoenixSQLParserTest.java:
##########
@@ -0,0 +1,24 @@
+package org.apache.phoenix.compile;
+
+import org.antlr.runtime.ANTLRInputStream;
+import org.antlr.runtime.CommonTokenStream;
+import org.apache.phoenix.parse.ParseNodeFactory;
+import org.apache.phoenix.parse.PhoenixSQLLexer;
+import org.apache.phoenix.parse.PhoenixSQLParser;
+import org.junit.Test;
+
+import java.io.InputStream;
+import java.io.StringBufferInputStream;
+
+public class PhoenixSQLParserTest {
+ @Test
+ public void testConstantInList() throws Exception {
+ InputStream stream = new StringBufferInputStream("select aCol from
aTable where aCol in (1, 2, 3)");
Review Comment:
I am bit confused, this is not related to atomic upsert right?
##########
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java:
##########
@@ -2531,7 +2529,7 @@ public boolean execute(String sql) throws SQLException {
}
executeMutation(stmt, createAuditQueryLogger(stmt, sql));
flushIfNecessary();
- return false;
+ return isResultSetExpected(stmt);
Review Comment:
Is it fine to return `true` even if the ResultSet is null?
##########
phoenix-core/src/test/java/org/apache/phoenix/compile/PhoenixSQLParserTest.java:
##########
@@ -0,0 +1,24 @@
+package org.apache.phoenix.compile;
Review Comment:
Missing Apache License
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
