haridsv commented on code in PR #2176:
URL: https://github.com/apache/phoenix/pull/2176#discussion_r2136884420
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/OnDuplicateKey2IT.java:
##########
@@ -589,10 +577,6 @@ public void testReturnRowResultWithoutAutoCommit() throws
Exception {
"IGNORE";
validateReturnedRowAfterUpsert(conn, upsertSql, tableName,
1011.202, null, true,
bsonDocument1, bsonDocument1, 123);
- throw new RuntimeException("Should not reach here");
- } catch (SQLException e) {
-
Assert.assertEquals(SQLExceptionCode.AUTO_COMMIT_NOT_ENABLED.getErrorCode(),
Review Comment:
Yes, that is why this assumption is no longer valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
