virajjasani commented on code in PR #2199:
URL: https://github.com/apache/phoenix/pull/2199#discussion_r2163093885


##########
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/PhoenixPreparedStatement.java:
##########
@@ -215,6 +215,28 @@ private void preExecuteUpdate() throws SQLException {
         }
     }
 
+    /**
+     * Executes the given SQL statement similar to JDBC API executeUpdate() 
but also returns the
+     * old row (before update) as Result object back to the client. This must 
be used with
+     * auto-commit Connection. This makes the operation atomic.
+     * Return the old row (state before update) regardless of whether the 
update is
+     * successful or not.
+     *
+     * @return The pair of int and ResultSet, where int represents value 1 for 
successful row update
+     * and 0 for non-successful row update, and ResultSet represents the old 
state of the row.
+     * @throws SQLException If the statement cannot be executed.
+     */
+    // Note: Do Not remove this, it is expected to be used by downstream 
applications
+    public Pair<Integer, ResultSet> executeAtomicUpdateReturnOldRow() throws 
SQLException {

Review Comment:
   I meant to say, the application has to unnecessarily import 
`org.apache.phoenix.execute.MutationState.ReturnResult` and besides old and new 
row are the only use case we are planning to support.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to