virajjasani commented on PR #2199: URL: https://github.com/apache/phoenix/pull/2199#issuecomment-3001231758
> No new if conditions added right? Also, you can create a verb out of the common conditions and make it even look cleaner. I meant, extra condition with `&&`, besides in all workflows ON DUP KEY UPDATE/IGNORE, `currColumnCellExprMap` map is updated only before returning from `generateOnDupMutations()`, which was quite straightforward for debugging purpose. Now if we update the map with currentRow in common place only for oldRow case and not newRow case, it really confuses reader. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
