virajjasani commented on code in PR #2225:
URL: https://github.com/apache/phoenix/pull/2225#discussion_r2208283223
##########
phoenix-core-client/src/main/java/org/apache/phoenix/query/QueryServices.java:
##########
@@ -383,6 +383,8 @@ public interface QueryServices extends SQLCloseable {
public static final String WAL_EDIT_CODEC_ATTRIB =
"hbase.regionserver.wal.codec";
//Property to know whether TTL at View Level is enabled
public static final String PHOENIX_VIEW_TTL_ENABLED =
"phoenix.view.ttl.enabled";
+ // TTL strict mode - when false, TTL is considered relaxed
+ public static final String PHOENIX_TTL_STRICT = "phoenix.ttl.strict";
Review Comment:
Yes, it should be supported on views too by default with this PR, unless i
am missing something. The primary goal of relaxed TTL is to ensure we don't
mask the rows while reading. It seems there is no view specific logic in
TTLRegionScanner. View specific TTL logic is available only in
CompactionScanner, which anyways is not expected to change regardless of strict
or relaxed TTL.
FYI @jpisaac if i missed something with view TTL masking logic. Do we have
anything specific?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
