sanjeet006py commented on code in PR #2225:
URL: https://github.com/apache/phoenix/pull/2225#discussion_r2210032591
##########
phoenix-core-client/src/main/java/org/apache/phoenix/schema/PTableImpl.java:
##########
@@ -2039,6 +2051,10 @@ public static PTable createFromProto(PTableProtos.PTable
table) {
if (table.hasChangeDetectionEnabled()) {
isChangeDetectionEnabled = table.getChangeDetectionEnabled();
}
+ boolean isStrictTTL = true;
Review Comment:
For consistency maybe good to use the `DEFAULT_IS_STRICT_TTL`?
##########
phoenix-core-client/src/main/java/org/apache/phoenix/schema/MetaDataClient.java:
##########
@@ -3669,6 +3681,12 @@ public boolean isViewReferenced() {
tableUpsert.setBytes(37, rowKeyMatcher);
}
+ if (isStrictTTLProp == null) {
+ tableUpsert.setNull(38, Types.BOOLEAN);
Review Comment:
How about setting this to `PTable.DEFAULT_IS_STRICT_TTL`? This way we can
consistent in treating NULL for `isStrictTTLProp`.
##########
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##########
@@ -1500,7 +1528,7 @@ && isPartialUncoveredIndexMutation(indexMetaData,
miniBatchOp))) {
onDupCheckTime += (EnvironmentEdgeManager.currentTimeMillis() -
start);
}
- if (context.hasConditionalTTL) {
+ if (context.hasConditionalTTL && isStrictTTLEnabled(miniBatchOp)) {
Review Comment:
Do we need this check as I see in the method call also we check if strictTTL
is enabled upfront?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
