ritegarg commented on code in PR #2244:
URL: https://github.com/apache/phoenix/pull/2244#discussion_r2237690240
##########
phoenix-core-client/src/main/java/org/apache/phoenix/query/QueryServices.java:
##########
@@ -140,7 +140,15 @@ public interface QueryServices extends SQLCloseable {
public static final String
MAX_SERVER_METADATA_CACHE_TIME_TO_LIVE_MS_ATTRIB =
"phoenix.coprocessor.maxMetaDataCacheTimeToLiveMs";
public static final String MAX_SERVER_METADATA_CACHE_SIZE_ATTRIB =
"phoenix.coprocessor.maxMetaDataCacheSize";
public static final String MAX_CLIENT_METADATA_CACHE_SIZE_ATTRIB =
"phoenix.client.maxMetaDataCacheSize";
- public static final String HA_GROUP_NAME_ATTRIB = "phoenix.ha.group";
+ public static final String HA_IMPLEMENTATION = "phoenix.ha.implementation";
+ // TODO: Revisit this default value based on standard ZK update time
+ // and time it takes for an update to reach regionserver cache.
+ // Refresh interval for store and forward mode status updates in
milliseconds
+ public static final String HA_STORE_AND_FORWARD_MODE_REFRESH_INTERVAL_MS =
"phoenix.ha.store.forward.mode.refresh.interval.ms";
+ // TODO: Revisit this default value based on standard ZK update time
+ // and time it takes for an update to reach regionserver cache.
+ // Refresh interval for sync mode status updates in milliseconds
+ public static final String HA_SYNC_MODE_REFRESH_INTERVAL_MS =
"phoenix.ha.sync.mode.refresh.interval.ms";
Review Comment:
Plan to remove this in next iteration. We will use
"zookeeper.session.timeout" with a multiplier(default 1.1) for this value.
Reason is that regionservers create ephemeral node in ZK once it starts and if
RS is not connected to ZK for "zookeeper.session.timeout" , RegionServerTracker
will abort the regionserver for which ephemeral node was deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
