ritegarg commented on code in PR #2244:
URL: https://github.com/apache/phoenix/pull/2244#discussion_r2241480785


##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java:
##########
@@ -1055,20 +1055,4 @@ public void 
preClose(ObserverContext<RegionCoprocessorEnvironment> c, boolean ab
     protected boolean isRegionObserverFor(Scan scan) {
         return 
scan.getAttribute(BaseScannerRegionObserverConstants.UNGROUPED_AGG) != null;
     }
-
-    @Override
-    public void preBatchMutate(ObserverContext<RegionCoprocessorEnvironment> c,

Review Comment:
   Discussed with @tkhurana and concluded that this is not needed anymore. We 
will be relying on IndexRegionObserver for mutation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to