leomy commented on issue #2330: URL: https://github.com/apache/plc4x/issues/2330#issuecomment-3497873792
> Hi Leomy and welcome :-) > > Thanks for that feedback ... yes indeed we're no Netty wizzards ;-) So your feedback is highly appreciated. > > However I would assume that changing this would not be a simple task. I guess it would requiring rewriting a larger portion of the SPI in order to do so. Are you willing to help work on this? I guess as all of our drivers follow the same model, it technically should apply to all of them, right? > > The problem is that we're only a hand full of people working on this in our free time. I just rewrote the entire PLC4J core to work completely without Netty for my commercial offering. > > Chris Hi, Chris. Thank you very much for this project. I discovered these issues during usage. However, I have currently implemented part of the S7 Client from scratch based on Netty (only sending and receiving functions), while the read and write functions have not been fully implemented yet. That said, my current implementation is completely detached from PLC4J's API design (i.e., quickly defining requests/responses via the protocol code generation tool). In my opinion, the code generated by this tool contains a large number of invalid objects and has poor performance. If it's possible to move away from that model, I would be happy to contribute my code to the project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
