dennishuo commented on code in PR #360: URL: https://github.com/apache/polaris/pull/360#discussion_r1792730325
########## polaris-service/src/main/java/org/apache/polaris/service/catalog/io/WasbTranslatingFileIO.java: ########## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.catalog.io; + +import java.util.Map; +import org.apache.iceberg.io.FileIO; +import org.apache.iceberg.io.InputFile; +import org.apache.iceberg.io.OutputFile; +import org.apache.polaris.core.storage.StorageLocation; +import org.apache.polaris.core.storage.azure.AzureLocation; + +/** + * A {@link FileIO} implementation that translates WASB paths into ABFS paths and then delegates to + * another underlying FileIO implementation + */ +public class WasbTranslatingFileIO implements FileIO { + private final FileIO io; + + private static final String WASB_SCHEME = "wasb"; + private static final String ABFS_SCHEME = "abfs"; + + public WasbTranslatingFileIO(FileIO io) { Review Comment: Oh I see you also have the endpoint rewrite from `blob` to `dfs` which wouldn't fit into that. I agree we might not want to go down the road of overly general regexes either. Per https://github.com/apache/iceberg/issues/10127#issuecomment-2080302481 the underlying Azure SDK doesn't actually seem to actually care about the endpoint and will internally sort into both a `dfs` and a `blob` client, so in theory a scheme-only replacement should still work, but I guess it could be more fragile. @collado-mike What do you think? Should we just keep this very wasb-specific? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
