collado-mike commented on code in PR #360: URL: https://github.com/apache/polaris/pull/360#discussion_r1793904244
########## polaris-service/src/main/java/org/apache/polaris/service/catalog/io/WasbTranslatingFileIO.java: ########## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.catalog.io; + +import java.util.Map; +import org.apache.iceberg.io.FileIO; +import org.apache.iceberg.io.InputFile; +import org.apache.iceberg.io.OutputFile; +import org.apache.polaris.core.storage.StorageLocation; +import org.apache.polaris.core.storage.azure.AzureLocation; + +/** + * A {@link FileIO} implementation that translates WASB paths into ABFS paths and then delegates to + * another underlying FileIO implementation + */ +public class WasbTranslatingFileIO implements FileIO { + private final FileIO io; + + private static final String WASB_SCHEME = "wasb"; + private static final String ABFS_SCHEME = "abfs"; + + public WasbTranslatingFileIO(FileIO io) { Review Comment: If I were designing this, I would have a `TransformingFileIO` with a constructor like ```java public TransformingFileIO(Function<String, String> pathTransformer, FileIOFactory delegate) { } ``` and the azure class would extend that class and pass in a function that did the wasb->abfs conversion. But that's the kind of code refactoring that can be done later without any compatibility or behavior impact, so... 🤷🏽♂️ ########## polaris-service/src/main/java/org/apache/polaris/service/catalog/io/WasbTranslatingFileIOFactory.java: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.catalog.io; + +import com.fasterxml.jackson.annotation.JsonTypeName; +import java.util.Map; +import org.apache.hadoop.conf.Configuration; +import org.apache.iceberg.CatalogUtil; +import org.apache.iceberg.io.FileIO; + +/** A {@link FileIOFactory} that translates WASB paths to ABFS ones */ +@JsonTypeName("wasb") +public class WasbTranslatingFileIOFactory implements FileIOFactory { + @Override + public FileIO loadFileIO(String ioImpl, Map<String, String> properties) { Review Comment: I don't think we can avoid working on this now. A production use case will require things like metering, throttling, as well as azure support. As is, the configuration only supports one IO factory, meaning you couldn't get all three without writing a new class that does all three. I think the configuration would work fine as ``` io: factoryType: chain delegates: - measured - wasb - default ``` I think dropwizard should support detecting the generic type argument in something like ``` public void setDelegates(List<FileIOFactory> delegates); ``` so the above configuration should work out of the box. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
