flyrain commented on code in PR #309:
URL: https://github.com/apache/polaris/pull/309#discussion_r1792847144
##########
polaris-service/src/main/java/org/apache/polaris/service/config/PolarisApplicationConfig.java:
##########
@@ -91,6 +91,7 @@ public void setPolarisAuthenticator(
}
public RealmContextResolver getRealmContextResolver() {
+ realmContextResolver.setDefaultRealm(this.defaultRealm);
return realmContextResolver;
Review Comment:
If we made the above change, I think we don't have to make the interface
changes in `RealmContextResolver`. We just need to add a constructor in the
class `DefaultContextResolver` like this
```
public DefaultContextResolver( @JsonProperty("defaultRealms") final String
defaultRealm) {
this.defaultRealm = defaultRealm;
}
```
Not setter and getter are needed in this way. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
