eric-maynard commented on code in PR #309:
URL: https://github.com/apache/polaris/pull/309#discussion_r1793703161
##########
polaris-service/src/main/java/org/apache/polaris/service/context/DefaultContextResolver.java:
##########
@@ -92,14 +92,22 @@ public RealmContext resolveRealmContext(
if (!parsedProperties.containsKey(REALM_PROPERTY_KEY)) {
LOGGER.warn(
- "Failed to parse {} from headers; using {}",
- REALM_PROPERTY_KEY,
- REALM_PROPERTY_DEFAULT_VALUE);
- parsedProperties.put(REALM_PROPERTY_KEY, REALM_PROPERTY_DEFAULT_VALUE);
+ "Failed to parse {} from headers; using {}", REALM_PROPERTY_KEY,
getDefaultRealm());
+ parsedProperties.put(REALM_PROPERTY_KEY, getDefaultRealm());
}
return () -> parsedProperties.get(REALM_PROPERTY_KEY);
}
+ @Override
+ public void setDefaultRealm(String defaultRealm) {
+ this.defaultRealm = defaultRealm;
+ }
+
+ @Override
+ public String getDefaultRealm() {
+ return this.defaultRealm;
+ }
Review Comment:
I don't think we should keep the setter but not the getter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
