collado-mike commented on code in PR #370:
URL: https://github.com/apache/polaris/pull/370#discussion_r1800146894
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java:
##########
@@ -249,12 +249,19 @@ public Builder setStorageConfigurationInfo(
break;
case AZURE:
AzureStorageConfigInfo azureConfigModel = (AzureStorageConfigInfo)
storageConfigModel;
- config =
+ AzureStorageConfigurationInfo azureconfigInfo =
new AzureStorageConfigurationInfo(
new ArrayList<>(allowedLocations),
azureConfigModel.getTenantId());
+
azureconfigInfo.setMultiTenantAppName(azureConfigModel.getMultiTenantAppName());
Review Comment:
For the AWS case, we cast to invoke a single specific method. Here we need
to invoke two methods. I think using the inline cast to invoke a single method
makes sense and doesn't hurt readability, whereas inline casting twice is
unnecessarily cumbersome, hence the intermediate variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
