collado-mike commented on code in PR #370:
URL: https://github.com/apache/polaris/pull/370#discussion_r1800150313
##########
polaris-service/src/test/java/org/apache/polaris/service/admin/PolarisServiceImplIntegrationTest.java:
##########
@@ -379,6 +382,73 @@ public void testCreateCatalogWithInvalidName() {
}
}
+ @Test
+ public void testCreateCatalogWithAzureStorageConfig() {
Review Comment:
CLI tests are fine, but I think the primary purpose of CLI tests is to
evaluate that the CLI behaves as expected. For the purpose of this PR, we're
fixing an API issue, so I think testing the API directly makes the most sense.
If the CLI isn't passing something to the API, that's a concern, but I don't
think we need to duplicate every API test in the CLI. Moreover, the CLI test
doesn't have the infrastructure for setting fake google credentials, so adding
tests there would require a pretty significant change and I don't know that
we'd get much more value for the extra work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
