lefebsy commented on code in PR #389:
URL: https://github.com/apache/polaris/pull/389#discussion_r1813183830


##########
spec/polaris-management-service.yml:
##########
@@ -901,6 +903,58 @@ components:
       required:
         - roleArn
 
+    S3StorageConfigInfo:

Review Comment:
   I think that roleArn is not mandatory for AWS S3.
   Using access and secret key should work with AWS S3 too.
   Same naming bad compromise explained previously. I agree to modify in a 
better suited way and be aligned with Polaris conventions



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to