lefebsy commented on code in PR #389:
URL: https://github.com/apache/polaris/pull/389#discussion_r1813209421


##########
spec/polaris-management-service.yml:
##########
@@ -901,6 +903,58 @@ components:
       required:
         - roleArn
 
+    S3StorageConfigInfo:
+      type: object
+      description: S3 compatible storage configuration info (MinIO, Dell ECS, 
Netapp StorageGRID, ...)
+      allOf:
+        - $ref: '#/components/schemas/StorageConfigInfo'
+      properties:
+        credsCatalogAndClientStrategy:
+          type: string
+          enum:
+            - VALUE
+            - ENV_VAR_NAME
+          default: ENV_VAR_NAME
+          example: "ACCESS_KEY"
+          description: When you send key VALUE directly via this command, they 
should apear in logs. By ENV_VAR_NAME without dollar, only a reference will 
appear in logs, but the value have to be available as environnement variable in 
the context where Polaris is running
+        credsVendingStrategy:
+          type: string
+          enum:
+            - TOKEN_WITH_ASSUME_ROLE
+            - KEYS_SAME_AS_CATALOG
+            - KEYS_DEDICATED_TO_CLIENT

Review Comment:
   Here client is anything trying to obtain keys (or security token service) 
from this catalog (spark, trino,...). There is no particular distinction of 
identity.
   
   This is not the right term to use in the context of Polaris?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to