collado-mike commented on code in PR #395:
URL: https://github.com/apache/polaris/pull/395#discussion_r1813416392
##########
polaris-core/src/main/java/org/apache/polaris/core/PolarisConfiguration.java:
##########
@@ -154,6 +154,14 @@ public static <T> Builder<T> builder() {
.defaultValue(false)
.build();
+ public static final PolarisConfiguration<Boolean>
ALLOW_EXTERNAL_CATALOG_CREDENTIAL_VENDING =
Review Comment:
The current impl allows setting the default value for the service and
allowing for catalog-level overrides. This is confirmed in the tests
[here](https://github.com/apache/polaris/pull/395/files#diff-38ed2dc48574ff5a3bf83463278cfa4e40ab8bb40abc4fe2aa58b46e6beb927fR793-R800)
and
[here](https://github.com/apache/polaris/pull/395/files#diff-38ed2dc48574ff5a3bf83463278cfa4e40ab8bb40abc4fe2aa58b46e6beb927fR860-R870).
This allows admins to turn off credential vending by default, but to enable it
on a case-by-case basis if they trust the external catalog or if the potential
for credential overreach is not a security concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
