sfc-gh-dhuo commented on code in PR #395:
URL: https://github.com/apache/polaris/pull/395#discussion_r1813199324
##########
polaris-core/src/main/java/org/apache/polaris/core/PolarisConfiguration.java:
##########
@@ -154,6 +154,14 @@ public static <T> Builder<T> builder() {
.defaultValue(false)
.build();
+ public static final PolarisConfiguration<Boolean>
ALLOW_EXTERNAL_CATALOG_CREDENTIAL_VENDING =
Review Comment:
Looks like the current code will support different keys for yaml-level
system-wide settings, while using the same catalogConfig for per-catalog
overrides, which does seem to achieve both goals.
I would agree that the yaml-level config is the main thing that needs to be
configurable separately by whoever is running the Polaris service.
If we can verify that it won't cause any problems to have the same
`catalogConfig("enable.credential.vending")` for both
`ALLOW_EXTERNAL_CATALOG_CREDENTIAL_VENDING` and
`ALLOW_INTERNAL_CATALOG_CREDENTIAL_VENDING` then this seems like the best
approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
