lefebsy commented on code in PR #389:
URL: https://github.com/apache/polaris/pull/389#discussion_r1813183830
##########
spec/polaris-management-service.yml:
##########
@@ -901,6 +903,58 @@ components:
required:
- roleArn
+ S3StorageConfigInfo:
Review Comment:
This implementation focuses on OnPrem S3 because there is already the AWS
class.. However, I can try to let it work seamlessly with AWS :
- I think that roleArn is not mandatory for AWS S3, so let it to the
existing implementation for this scenario
- Using access and secret key should work with AWS S3 too
- I have overrided the AWS STS endpoint with S3 endpoint. I could add a
modification, maybe with a STS endpoint property... something like "if property
is empty" -> "STSclient call AWS default STS endpoint" else -> "STS client call
the endpoint setted" or a boolean with a clear and explicit description
- I have removed the cross region tweak of the AWS FileIOClientFactory, it
can be kept to assure a full compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
