adutra commented on code in PR #435:
URL: https://github.com/apache/polaris/pull/435#discussion_r1833342877
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/MetaStoreManagerFactory.java:
##########
@@ -33,7 +32,7 @@
* configuration
*/
@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, include = JsonTypeInfo.As.PROPERTY,
property = "type")
-public interface MetaStoreManagerFactory extends Discoverable {
Review Comment:
Interesting, isn't this going to disturb Dropwizard's so-called
["polymorphic
configuration"](https://www.dropwizard.io/en/release-3.0.x/manual/configuration.html#polymorphic-configuration)?
It seems we rely heavily on that feature though:
https://github.com/apache/polaris/blob/7b2cca4add23e7be369971774a55ce3dae7cca14/polaris-service/src/main/resources/META-INF/services/io.dropwizard.jackson.Discoverable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
